search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.43k stars 519 forks source link

Changing Appearance -> Buttons -> Thanks to "Hidden" does not work #2364

Open michaelrogers0 opened 3 months ago

michaelrogers0 commented 3 months ago

Changing Appearance -> Buttons -> Thanks to "Hidden" does not work when the "Thanks" button has been tucked away inside the "..." button.

raszpl commented 3 months ago

do you have a link to yt video with thanks button handy for testing?

michaelrogers0 commented 3 months ago

Hi @raszpl,

Sure, here is an example YT video that uses the Thanks button: https://www.youtube.com/watch?v=-A9F2ag8Jhw

Thank you for looking into this :)

raszpl commented 3 months ago

looks like our settings dont consider entries hidden in the hamburger menu https://github.com/search?q=repo%3Acode-charity%2Fyoutube%20ytd-menu-service-item-renderer&type=code Im not sure if that was even the intend of those options.

adding html[it-hide-thanks-button='hidden'] ytd-menu-service-item-renderer:has(svg path[d^="M11 17h2v-1h1c.55 0"]), to https://github.com/code-charity/youtube/blob/c78a7875ddd2e4a5ec7115a30c4096c7f2225c70/js%26css/extension/www.youtube.com/appearance/details/details.css#L67-L70 removes it from menu too. Ill let someone else make a patch.

ImprovedTube commented 2 months ago

Im not sure if that was even the intend of those options.

hi! @michaelrogers0 as a sub-option when hiding it: hide in the "..."-menu too?

michaelrogers0 commented 2 months ago

Hi @ImprovedTube! Yes, implementing it as a sub-option as you described would be perfect. Also, just wanted to say, love this extension, so useful :)