search

code-chronicles-code / leetcode-curriculum

https://code-chronicles-code.github.io/leetcode-curriculum/
MIT License
9 stars 12 forks source link

Add level order traversal Kotlin goody #369

Closed willmadison closed 3 months ago

willmadison commented 3 months ago

Closes #314.

miorel commented 3 months ago

Regarding the checks: you can take a look at the job summary (see for example https://github.com/code-chronicles-code/leetcode-curriculum/actions/runs/10514921554?pr=369) to see what failed. It looks like it's the snapshot tests. You will have to run yarn package-goodies:test -u somewhere within the workspaces/adventure-pack directory to update the snapshots, sorry this is not better documented. The context is that we have some snapshot tests that assert each goody can be extracted successfully. I broke goody extraction at least once before so this has been helpful to have. It also highlights when a change to the extraction code changes what will be shown on the website.

Separately I see that you already discovered I prefer the more concise 2 space indentation rather than the 4, hope that's not too annoying for you 😄