search

code-lts / doctum

A php API documentation generator, fork of Sami
https://doctum.long-term.support/
MIT License
300 stars 32 forks source link

Fix #18 Make releative paths work using phars #22

Closed ptomulik closed 3 years ago

ptomulik commented 3 years ago

This makes my test.tar.gz to work, so I believe it fixes #18. To test it, please tar -xzf test.tar.gz && cd test/ && doctum.phar update --force -v docs/doctum-relative.conf.php (using doctum.phar generated from this PR).

williamdes commented 3 years ago

By the way do you have a GPG key ?

ptomulik commented 3 years ago

By the way do you have a GPG key ?

Not ATM. I mean I used GPG key(s) for email but it got me a lot of headache one day my signature expired, so I just abandoned my GPGs for a moment :)

williamdes commented 3 years ago

Not ATM. I mean I used GPG key(s) for email but it got me a lot of headache one day my signature expired, so I just abandoned my GPGs for a moment :)

If you still have the private key you can extend the expiration date and use them ;) This can be useful to upload the key: https://gist.github.com/williamdes/0d49288fecf83bf491cc1e6366ae7c30#upload-the-key I can help you if you want, let 2021 be a year with a working key to sign commits and tags ;p

williamdes commented 3 years ago

I added bash tests: https://github.com/code-lts/doctum/runs/1595354287?check_suite_focus=true#step:4:132

williamdes commented 3 years ago

5.3.1 is out with your fix, thank you !