search

code-lts / doctum

A php API documentation generator, fork of Sami
https://doctum.long-term.support/
MIT License
300 stars 32 forks source link

Check exception format #36

Closed fjgarlin closed 3 years ago

fjgarlin commented 3 years ago

Fixes #35

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (576864c) into main (d8186b0) will increase coverage by 0.28%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #36      +/-   ##
============================================
+ Coverage     56.34%   56.62%   +0.28%     
- Complexity     1159     1160       +1     
============================================
  Files            51       51              
  Lines          3012     3013       +1     
============================================
+ Hits           1697     1706       +9     
+ Misses         1315     1307       -8
Impacted Files Coverage Δ
src/Reflection/MethodReflection.php 36.11% <100.00%> (+12.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8186b0...576864c. Read the comment docs.

williamdes commented 3 years ago

I did re-write the fix so it is not based on an else statement. Also added tests for it. Thanks a lot for the initial fix !

williamdes commented 3 years ago

This is now in the latest dev phar. See: https://github.com/code-lts/doctum#installation

curl -O https://doctum.long-term.support/releases/5-dev/doctum.phar && chmod +x doctum.phar
fjgarlin commented 3 years ago

Thanks for the info above and for the tests.