search

code100x / tiplink

MIT License
173 stars 197 forks source link

added skeleton ui for appbar when status is loading #188

Open Bhushan-04 opened 2 months ago

Bhushan-04 commented 2 months ago

Pull Request Title

Thank you for contributing to our project! Please provide a summary of your changes and reference any related issues below.

Issue Number: Fixes #172

🛠️ Type of Change

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

fix : problem : Session is picked up after the page fully loads and therefore leading to a delay in the rendering of user image and wallet icon

Solution : Added Skeleton when status is loading to avoid delay in rendering of image and wallet icon

Before : https://github.com/user-attachments/assets/df6063a2-4ddf-4a5f-a25c-4e462bef6b64

After: When User is not logged in- https://github.com/user-attachments/assets/d84e105b-f059-4b4d-889c-31ee660d4920

When User is logged in- https://github.com/user-attachments/assets/6d0b674e-bbca-42b3-a30d-e8bbb89e3b14

Ameerjafar commented 2 months ago

@cb7chaitanya what about this pr.

cb7chaitanya commented 2 months ago

What about it? @Ameerjafar I am not going to merge it @Bhushan-04 as the issue was assigned to @Ameerjafar and I can only merge it if @Ameerjafar is not going to turn up with a PR

Ameerjafar commented 2 months ago

Ok sir let me make the pr @cb7chaitanya

On Fri, 20 Sep, 2024, 8:06 pm cb7chaitanya, @.***> wrote:

What about it? @Ameerjafar https://github.com/Ameerjafar I am not going to merge it @Bhushan-04 https://github.com/Bhushan-04 as the issue was assigned to @Ameerjafar https://github.com/Ameerjafar and I can only merge it if @Ameerjafar https://github.com/Ameerjafar is not going to turn up with a PR

— Reply to this email directly, view it on GitHub https://github.com/code100x/tiplink/pull/188#issuecomment-2363884639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE45SIXG4UCF3WWFOIBNRDZXQXFVAVCNFSM6AAAAABORVQTF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTHA4DINRTHE . You are receiving this because you were mentioned.Message ID: @.***>

Bhushan-04 commented 2 months ago

What about it? @Ameerjafar I am not going to merge it @Bhushan-04 as the issue was assigned to @Ameerjafar and I can only merge it if @Ameerjafar is not going to turn up with a PR

Sure , no problem sir !