code100x / tiplink

MIT License
173 stars 197 forks source link

[FEAT]:QR code receive functionality added #211

Closed Rudra-Sankha-Sinhamahapatra closed 1 month ago

Rudra-Sankha-Sinhamahapatra commented 1 month ago

Pull Request Title

Thank you for contributing to our project! Please provide a summary of your changes and reference any related issues below.

Issue Number: Fixes #202

🛠️ Type of Change

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:


We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

I have added a QR code generation of the publicKey of the user available on the db

Here's a breif of it

https://github.com/user-attachments/assets/549ed1e7-fa1a-407b-be5d-ebc8599eb980

cb7chaitanya commented 1 month ago

Is scanning this QR code actually spitting out the user's public key?

cb7chaitanya commented 1 month ago

Also I would appreciate if you keep the receive tab's code in a dedicated component, and render it conditionally depending on what option is selected within our interface because we have other options we have to provide for which we would have to create seperate components too

Rudra-Sankha-Sinhamahapatra commented 1 month ago

Haan after scanning the QR code it shows the public key which is in the db And yes whenever we click the recieve then only this pops up And when we click other options like send and all it does not do anything @cb7chaitanya

cb7chaitanya commented 1 month ago

Ok but if we can keep components specific to options we are providing, that would be appreciated

Because otherwise walletDetail component would look too cluttered

Rudra-Sankha-Sinhamahapatra commented 1 month ago

@cb7chaitanya done see i have made it in separate component

WhatsApp Image 2024-10-04 at 17 22 27_37187cf4

image

see my db publicKey is in the qr .. you can scan the qr to be sure

cb7chaitanya commented 1 month ago

Works, good work @Rudra-Sankha-Sinhamahapatra