code4lib / 2022.code4lib.org

Website for the 2022 Conference
https://2022.code4lib.org/
2 stars 3 forks source link

Update 'Welcome' Message #29

Closed dzoladz closed 3 years ago

dzoladz commented 3 years ago

During today's meeting, Jerry proposed a rewrite of the welcome message for the Buffalo conference to include SUNY Buffalo or State University of New York at Buffalo... I don't recall the specifics of the language at the moment.

The welcome message can be found in the main index.html file in the project's root directory.

yarnetsky commented 3 years ago

@dzoladz Draft message in pull request #34

Hopefully it's not too cheezy, but it explains the theme a bit

(additional gems required for me to build repo on a windows machine, feel free to ignore)

dzoladz commented 3 years ago

I'm fine with a longer-than-previous-conferences welcome message.

When Nicola Tesla flipped the switch for the world's first long-range transmission of electricity in 1896, Buffalo became the City of Light. This spirit of innovation glows brighter than ever in Buffalo which makes it the perfect location for our 2022 Code4Lib Conference. Being hosted by the State University of New York at Buffalo, details on our venue are coming soon!

I'll need to confirm that the CSS works properly with a longer text on small screens. I can do that this evening.

Other thoughts?

phette23 commented 3 years ago

If we're going to be editing the welcome message each year, should it be a config variable? Just a thought, I'm not necessarily into that, it might be awkward if we want to insert a lot of links or other HTML. As is, I think the new text is a big improvement.

There definitely are some responsiveness problems in the range of <1000px width to before the phone-sized screen breakpoint where the star image is on its own line. The text overlaps the image in between those breakpoints.

Screen Shot 2021-11-08 at 1 53 21 PM
yarnetsky commented 3 years ago

Yep, this is a draft. At this point, I was wondering if this is even the type of message that could be envisioned here as it'd not been done before. If so I still need to tweak it, then I figure out how the css for the section works.

Offloading it to a variable makes good sense to me.

dzoladz commented 3 years ago

@yarnetsky I'll let you poke around with this a little more. Feel free to reach out if you want some help with it.

yarnetsky commented 3 years ago

I got the wording to flow better, and remembered the bootstrap class I was trying to recall so the section now responsive. Also moved the the catchline and welcome message to the conf.yml file under the venue section so it should all be editable in one shot.

phette23 commented 3 years ago

I get a build error because of the unescaped apostrophe in venue.welcome-message but otherwise this looks good and I did some responsiveness testing and it looked good at any window width. For the welcome-message, YAML lets you just not use quotes to wrap text fields so I'd do that:

venue:
    reserved-room-block: false
    name: ' '
    ...
    with-tax-cost: ''
    cost-cutoff-date: 2021-01-01
    welcome-message: In 1896, when Nicola Tesla initiated the world's first long-range transmission of electricity, Buffalo became the City of Light. Today, from biomedical research to the arts, this spirit of innovation glows brighter than ever, which makes Buffalo a perfect location for our 2022 Code4Lib Conference. Hosted by the State University of New York at Buffalo, details on our venue are coming soon!
    catchline: 'the City of Light'
yarnetsky commented 3 years ago

@phette23 Go figure. Makes perfect sense you'd get the build error. I'm trying to figure why I didn't get one. Are some machines or apps stricter in builds than others?

I was using a GitHub Codespaces virtual machine for my build and testing this morning. (still can't get my new Apple M1 to work on the repo and didn't have my windows machine available).

dzoladz commented 3 years ago

Are some machines or apps stricter in builds than others?

I'd expect any YAML linter to flag that one with default settings, but most linters do allow some level of configuration on how strictly to adhere to a rule set. For example: yamllint rules

phette23 commented 3 years ago

It's entirely possible (well, very likely) my environment is slightly different and so the YAML parsing is stricter.

yarnetsky commented 3 years ago

Try again. I took the easy way out and rewrote the sentence to avoid the apostrophe.

I reviewed the rules on strings — it's been a while since I've worked with YAML and a refresher is good either way. I see where quotes are not needed for strings unless you have characters that need escaping. But I'm not seeing an answer about something I'm seeing in our conf.yml file — does it matter if we use three quote methods in the same file? (no, single, and double quotes on strings without escape characters)

dzoladz commented 3 years ago

But I'm not seeing an answer about something I'm seeing in our conf.yml file — does it matter if we use three quote methods in the same file? (no, single, and double quotes on strings without escape characters

I'll open a new issue for this and merge your PR in just a moment.

phette23 commented 3 years ago

Just confirming that the site builds for me with the new commits.