code4romania / mon-vot-android-kotlin

Android election monitoring app - a mobile app through which commissioned observers can easily report back to their respective NGOs throughout the election day
https://votemonitor.org
Mozilla Public License 2.0
7 stars 29 forks source link

Use the orderNumber field for sorting #222

Closed lukstbit closed 4 years ago

lukstbit commented 4 years ago

Closes #218 The new orderNumber field will be used for sorting the sections, questions and answers in the questions related ViewModels. My implementation assumes that the orderNumber that comes from the API will be >= 1 because I set the default value for this field to 0(when doing the migration).

How has it been tested?

The PR includes additional instrumented tests for the database migrations needed to use the new field. And I also tested it manually.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication