use appropriate lifecycle owner instead of "this"

code4romania / mon-vot-android-kotlin

Android election monitoring app - a mobile app through which commissioned observers can easily report back to their respective NGOs throughout the election day

https://votemonitor.org

Mozilla Public License 2.0

7 stars 29 forks source link

use appropriate lifecycle owner instead of "this" #223

Closed mrwhoknows55 closed 4 years ago

mrwhoknows55 commented 4 years ago

also lot of places activity!!, parentFragment!! is being used, which can be replaced by requireActivity() and requireParentFragment()

lukstbit commented 4 years ago

The changes you made are already present in #221

mrwhoknows55 commented 4 years ago

@lukstbit Oh, I didn't knew about it. Should I close the PR?

aniri commented 4 years ago

@lukstbit @mrwhoknows55 thank you both for your help! yes, this issue was tackled in #221 , which is currently pending verification. I think we could keep it there and close the PR related to this one :/

Also, it would be awesome if you could offer some feedback on #221 as it brings a lot of changes :/