search

code4sac / bikeandwalk

Bike and Ped traffic counting web app
app.bikeandwalk.org
5 stars 0 forks source link

readying this for python3? #24

Open sohail288 opened 7 years ago

sohail288 commented 7 years ago

Hey all,

I want to get involved with code4sac and I thought I'd help out by updating this project to the latest versions of python, flask, sqlalchemy (not sure if we want this judging from earlier issues). Along with that, I'm planning on improving the general code. In addition I'll also contribute tests for the code :)

I'll open a pull request to contain the changes that i'm making and once I'm done, we can merge those into this fork's master.

So before I jump the gun, is this project planning on updating to Python3?

wleddy commented 7 years ago

Hi,

Thanks for pitching in!

Python 3: I don't really have a "plan" to upgrade but I'd sort of assumed it would need to happen at some point. I've never done anything in 3 so I could sure use some help.

SQLAlchemy: Yes I'd like to get rid of it because I feel like it adds complexity without providing much value. If you have a different take on it please let me know. That said, it there and it's working so it's not a priority.

Tests: Yes please! I should have done it long ago, but then, my plan was to be the project manager and let someone else write the app. 8-(

Regards, Bill Leddy

On Feb 25, 2017, at 6:17 PM, Sohail Khan notifications@github.com wrote:

Hey all,

I want to get involved with code4sac and I thought I'd help out by updating this project to the latest versions of python, flask, sqlalchemy (not sure if we want this judging from earlier issues). Along with that, I'm planning on improving the general code. In addition I'll also contribute tests for the code :)

I'll open a pull request to contain the changes that i'm making and once I'm done, we can merge those into this fork's master.

So before I jump the gun, is this project planning on updating to Python3?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

sohail288 commented 7 years ago

great! I'll get started on it. As far as priority goes, I am going to write tests first and then later refactor the application. I'll keep SQLAlchemy for now. The power will come in the form of having a flexible data persistence layer. Coupled with Alembic, it will allow an easier schema migration process.

wleddy commented 7 years ago

Great!

Are you planning on going to the meetup on Wednesday? I'd love to talk with you.

Regards, Bill Leddy

On Feb 28, 2017, at 12:37 AM, Sohail Khan notifications@github.com wrote:

great! I'll get started on it. As far as priority goes, I am going to write tests first and then later refactor the application. I'll keep SQLAlchemy for now. The power will come in the form of having a flexible data persistence layer. Coupled with Alembic, it will allow an easier schema migration process.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

sohail288 commented 7 years ago

I may not be able to come to the March 1st meetup. I will probably attend the first meetup after March 22nd. Until then, you can contact me through google+ at sohail@sohailkhan.me