search

codebrainz / geany-themes

A collection of colour schemes for Geany.
Other
581 stars 156 forks source link

Inclusion of Base16 themes #35

Open landroni opened 10 years ago

landroni commented 10 years ago

Please add support for the Tomorrow themes ( https://github.com/chriskempson/tomorrow-theme#readme ). As far as I go they're pretty excellent and I think that they'd make a great addition to Geany's selection of themes.

landroni commented 10 years ago

Actually Base16 is sufficient to cover most of Tomorrow themes. Soon we will make a PR for including base16: https://github.com/RobLoach/base16-geany , but not yet.

landroni commented 10 years ago

See also: https://github.com/RobLoach/base16-geany/issues/3

landroni commented 10 years ago

As per https://github.com/RobLoach/base16-geany/issues/4, most issues with the base16-geany themes have been addressed, and now we're ready to make a PR.

Last time we discussed this, you suggested that it would be better for the names to avoid clustering (Base16 3024 Dark) and that instead the names should be of the type: 3024 Dark (Base16). Do you still think that we should rename all themes like this? I'm asking since doing that would create some awkward theme names like Default (Base16). Please let me know how it would be best to proceed.

Also please check the themes at https://github.com/RobLoach/base16-geany/ and try them out to see if any obvious issues emerge. I already did my best to test them as per https://github.com/codebrainz/geany-themes/blob/master/ADDING-A-THEME.md .

RobLoach commented 10 years ago

Glad we can start the discussion. Didn't even think of including Base16 in Geany itself. Thanks for starting this up, @landroni.

yeknava commented 10 years ago

maybe this can help: https://github.com/yeknava/geany-tomorrow-night-color-scheme

landroni commented 10 years ago

I suspect that Base16 already contains Tomorrow Night, even if not by that name. (It's quite possibly the default dark theme.)

codebrainz commented 9 years ago

Sorry for the long delay. Are the themes auto-generated? If so (or even if not), is it possible to change the [theme_info] a bit? It would be nice if the names followed geany-themes convention a bit more, I was thinking something like 3024 (dark, base16) or something, so they sort in with the rest of the themes but still people can tell which are the base16 ones. Also the version should be just a number (ex. 0.2.2->22 or some such) because the theme version gets bumped automatically whenever the theme changes. Lastly, there should be a screenshot for each theme so people can see what they look like before downloading, and also for eventually being listed in some time of "catalog" (probably will be put on wiki eventually).

I started doing the above by hand but there's so many themes and it will take a long time to do that manually.