search

codebutler / farebot

Read data from public transit cards using your NFC Android phone!
http://codebutler.github.com/farebot
GNU General Public License v3.0
966 stars 271 forks source link

Merge Farebot M into upstream (Opal, Manly Fast Ferry) #110

Closed micolous closed 8 years ago

micolous commented 9 years ago

This fork contains the following changes:

  1. Crashalytics is deprecated, replace with Fabric. Please check that your API key still works.
  2. Detects fully encrypted Mifare Classic (MFC) cards and displays a special warning for them.
  3. Adds licensing screen (upstream was not compliant with licensing requirements)
  4. Adds support for Opal (Sydney, AU) (fixes #105)
  5. Adds support for Manly Fast Ferry Smartcard (Sydney, AU) (requires MFC support + keys)
  6. Adds detection for Mifare Classic support on device
  7. Adds about screen (which shows NFC debug info and version)
  8. Recompresses graphical resources to save space
  9. Tags releases with git metadata
  10. Localises date and time values according to device preferences, rather than hard coding (in a few different ways in different places)
  11. Allows MFC keys to be specified in any order in farebotkeys files, and only once for cards that use the same key for multiple sectors (eg: Manly)
  12. Signing configuration no longer hard coded into Manifest
  13. Supported card lists are now alphabetical, and show when the card is not supported on the device

I haven't completely gone through the other transit providers to check the copyright lists, as copyright assignment state is unknown.

This fork works for me on Manly, Opal and Suica cards.

micolous commented 9 years ago

Hey @codebutler,

I've tried emailing you about merging this pull request, and asking clarifying questions about getting this fork back into mainline again. Unfortunately I haven't heard from you in the last few weeks.

Honestly, I'm annoyed, given I spent about 8 hours rebasing my code in an attempt to merge my changes back into upstream, and it's been radio silence since then.

Please clarify if there are outstanding issues with this, as I am looking to merge this request.

I've put further changes on hold until this patch lands, because I don't want to go through a massive refactoring process all over again.

If you're not interested in merging again, that's fine, I'll continue development on my branch again and run under the assumption that upstream support has retired. In that process I'll also be looking to remove the "beta" distribution limitation from my package on the Play Store.

I can still see you're active on Twitter, but your GitHub activity has ceased following joining your current employer. Given this, I think you've lack time or interest to maintain Farebot. I would appreciate honesty and transparency from you about the commitments that you can or can't make. :smile:

I'm looking forward to hearing from you.

Thanks,

Michael

micolous commented 8 years ago

I've started working on other cards now (specifically #10), and I've heard nothing from you. As a result, I'll go off and do my own thing.

You do not seem interested in maintaining Farebot further, and I'm not interested if you're going to waste my time.