search

codecheckers / codecheck

R package assistant for conducting a CODECHECK
MIT License
10 stars 3 forks source link

not loading packages #33

Open sje30 opened 11 months ago

sje30 commented 11 months ago

it doesn't automatically load 'zen4R'or 'yaml' when the package is loaded. yet, those packages are listed on the Imports: part of DESCRIPTION. What am I missing?


> setwd('/Users/stephen/proj/2020/codecheckers/rmr-solver/codecheck')
> library("codecheck")
Loading required package: gh
Loading required package: R.cache
R.cache v0.16.0 (2022-07-21 16:20:02 UTC) successfully loaded. See ?R.cache for help.
Loading required package: parsedate
Loading required package: git2r
> metadata = read_yaml( "../codecheck.yml")
Error in read_yaml("../codecheck.yml") : 
  could not find function "read_yaml"
sje30 commented 11 months ago

ok, now I seee there are two things:

Depends:

Imports:

what's the best thing to do here @nuest ? I don't understand. e.g. the package doesn't install zen4R for use but we clearly need it to use the package. but in that case, shouldn't all of our 'Imports' statements be 'Depends'>

nuest commented 11 months ago

The DESCRIPTION file might still be from a time when zen4R was not on CRAN, so I see no reason not to make these changes.

IIRC the DESCRIPTION file should be updated by roxygen2 as well, but I may be mistaken.