search

codecov / codecov-browser-extension

A browser extension for Codecov. Works for Chrome and Firefox
Apache License 2.0
36 stars 11 forks source link

Safari extension support #22

Open mwarkentin opened 1 year ago

mwarkentin commented 1 year ago

It would be great to support this extension in Safari!

Apple has some docs about converting an existing web extension for use in Safari so maybe this wouldn't be too much work. :)

Image

eliatcodecov commented 1 year ago

Thanks for posting! I can't give a definitive time frame on this, but we'll take a look and see how much work would go into this. If it's straightforward, we can try to slot it in.

spalmurray-codecov commented 2 weeks ago

Using the linked conversion program apple provides, the extension Immediately works for file coverage, as pictured. PR coverage does not work, couldn't easily find the bug and don't want to continue spending time on this until we decide we want to move forward with this. I can't see any reason why it wouldn't work though, once that bug is squashed. There also seems to be some investigation and work to do around adapting the extension for safari and integrating the safari build into our CD pipeline. All of that being said, at first glance it seems like this should be a relatively painless conversion.

Image

spalmurray-codecov commented 2 weeks ago

Upon further investigation into the bug, it seems Safari handles cookie access differently to chrome and ff. I could not find a workaround using Safari APIs, but if we add support for using a Codecov API key for cloud Codecov, the Safari conversion should work!