search

codecrafters-io / frontend

Rebuild complex systems from scratch
https://app.codecrafters.io/catalog
Other
63 stars 13 forks source link

SCSS compilation is broken in production #2339

Open VasylMarchuk opened 1 month ago

VasylMarchuk commented 1 month ago

Brief

It appears that SCSS files included from app.css are not compiled correctly on production. It also looks like, we aren't really using any SCSS syntax in the few .scss files we have.

We should either rename those files to just .css for clarity, and remove any mentions of SCSS support, or fix it.

Details

Example commit that works when running locally (nested syntax works and style is applied) and stops working after publishing to production (nested syntax doesn't work, only plain CSS selectors): https://github.com/codecrafters-io/frontend/pull/2204/commits/9fe2f7b70105f98deb87756fe0cd8ca3ee1c3a81

rohitpaulk commented 1 week ago

Let's go with just renaming to .css for now - if we haven't needed scss so far, doesn't seem worth putting in the effort to make it work