search

codeday / www-clear

Internal tool for CodeDay event planning
https://clear.codeday.org
4 stars 6 forks source link

Added rounded edges to skyline image #5

Closed ShubhamPatilsd closed 2 years ago

ShubhamPatilsd commented 2 years ago

Made images round on the events page so they look better:

Rounded image

Very very low priority PR but yeah

vercel[bot] commented 2 years ago

@ShubhamPatilsd is attempting to deploy a commit to the CodeDay Team on Vercel.

A member of the Team first needs to authorize it.

oohwooh commented 2 years ago

I think this kind of clashes with the only-slightly rounded edges of the InfoBox, maybe just make these rounded edges match that? One other change that would be nice to have is a fallback image for if there isn't a skyline photo

ShubhamPatilsd commented 2 years ago

I'll try to do this later this week

ShubhamPatilsd commented 2 years ago

Hey, so I added the border-radius fix (changed it to border={3}) and I just used the CodeDay logo as the fallback image. I don't have a Clear setup (with env vars and stuff) on my local machine since I didn't want to go through so much for that little of a stylistic change. I expect it to work but then again let me know if it acts up.

oohwooh commented 2 years ago

lgtm! Thanks Shubham :)