search

codeforamerica / ebt-near-me

A mobile app that shows the nearest places you can use an EBT card nationwide.
http://ebtnearme.org
MIT License
9 stars 15 forks source link

App refactor #50

Closed jdungan closed 9 years ago

jdungan commented 9 years ago

Hi. Jake led me to your project and I got the itch to refactor it for issue #31.

Things I did: -Moved the js to it's own nearme.js file -Added my own Location object -Created a nearme object to keep stuff out of the global name space -Added user tracking -Requery for ebt locations when the map moves

The user marker will move if you change locations. It does not change the map view point or requery. This keeps the view from snapping back to the location if the user moves the map. Once you start adding more UI maybe it needs a 'find me' button to take you back to the user location.

Hope it helps and I look forward to helping with this project.

John Dungan Code for Tulsa

fureigh commented 9 years ago

Very cool, thanks so much! I'm traveling and in meetings all day but look forward to reviewing this PR tonight.

On Oct 26, 2014, at 6:53 AM, jdungan notifications@github.com wrote:

Hi. Jake led me to your project and I got the itch to refactor it for issue #31.

Things I did: -Moved the js to it's own nearme.js file -Added my own Location object -Created a nearme object to keep stuff out of the global name space -Added user tracking -Requery for ebt locations when the map moves

The user marker will move if you change locations. It does not change the map view point or requery. This keeps the view from snapping back to the location if the user moves the map. Once you start adding more UI maybe it needs a 'find me' button to take you back to the user location.

Hope it helps and I look forward to helping with this project.

John Dungan Code for Tulsa

You can merge this Pull Request by running

git pull https://github.com/codefortulsa/ebt-near-me app-refactor Or view, comment on, or merge it at:

https://github.com/fureigh/ebt-near-me/pull/50

Commit Summary

initial refactor with Location object track map moves and get more ebt locations File Changes

M index.html (96) A public/js/nearme.js (128) Patch Links:

https://github.com/fureigh/ebt-near-me/pull/50.patch https://github.com/fureigh/ebt-near-me/pull/50.diff — Reply to this email directly or view it on GitHub.