codeforboston / home-energy-analysis-tool

https://www.codeforboston.org/projects/
MIT License
8 stars 25 forks source link

Dockerfile should build `rules-engine` #116

Open thadk opened 7 months ago

thadk commented 7 months ago

Right now the web app deployment only deploys an obsolete no-dependency python rules-engine file. With the newest version of the Rules Engine in the repository, it is using a python package wheel (whl) file which needs to be built on every deployment.

The whl file is already getting built for use in the unit tests. The test is committed and passing.

But we can't use the Rules Engine whl file yet in the browser, and we'd like to. You can help.

We don't want to check in the whl file, but to build it "just-in-time" at the key places. There is a reference example to help you start. It runs whenever we do npm run test app/utils/pyodide.test.ts

Dockerfile build of the Python whl

Optional: Package.json enable npm run dev to build & copy the whl

Fix Github Actions to match

zganger commented 5 months ago

I'm looking to onboard on this project and I have experience in python and in automation. I could take this one.

thadk commented 4 months ago

Hi @zganger, thanks for that note and welcome! Let me know what parts sound interesting.

I think Greg (@thatoldplatitude ) from the Rules Engine python team started on the Dockerfile part of this in #146 . @thatoldplatitude if you could compare and contrast your PR to what is described above that would be helpful.

I would like to pursue this issue as a subgroup and would be happy to set up non-tuesday night meeting(s) this next week or answer any questions on moving forward for the tasks above.

thatoldplatitude commented 4 months ago

Just getting to these tags. We could for sure setup a non-tuesday meet -- sry wasn't available much this week. But there are for sure a few ways to go about this. I assumed a few things:

But if we want to have separate meet, it may be easier for us to review options.