Open thadk opened 7 months ago
I'm looking to onboard on this project and I have experience in python and in automation. I could take this one.
Hi @zganger, thanks for that note and welcome! Let me know what parts sound interesting.
I think Greg (@thatoldplatitude ) from the Rules Engine python team started on the Dockerfile part of this in #146 . @thatoldplatitude if you could compare and contrast your PR to what is described above that would be helpful.
I would like to pursue this issue as a subgroup and would be happy to set up non-tuesday night meeting(s) this next week or answer any questions on moving forward for the tasks above.
Just getting to these tags. We could for sure setup a non-tuesday meet -- sry wasn't available much this week. But there are for sure a few ways to go about this. I assumed a few things:
But if we want to have separate meet, it may be easier for us to review options.
Right now the web app deployment only deploys an obsolete no-dependency python rules-engine file. With the newest version of the Rules Engine in the repository, it is using a python package wheel (whl) file which needs to be built on every deployment.
The
whl
file is already getting built for use in the unit tests. The test is committed and passing.But we can't use the Rules Engine
whl
file yet in the browser, and we'd like to. You can help.We don't want to check in the
whl
file, but to build it "just-in-time" at the key places. There is a reference example to help you start. It runs whenever we donpm run test app/utils/pyodide.test.ts
Dockerfile build of the Python
whl
mv Dockerfile ./heat-stack
as it instructs, try moving it to the root of the project.heat-stack
Dockerfile in a way so the../rules-engine
folder can do a build.rules-engine
folder into the built docker image.vitest
in the otherpackage.json
example: https://github.com/codeforboston/home-energy-analysis-tool/blob/0b6f2d11b264a1db9d84ba5c1c52da5c07e93c0e/heat-stack/package.json#L23rules-engine/dist/rules_engine-*-py3-none-any.whl
heat-stack/public/pyodide-env
Optional: Package.json enable
npm run dev
to build & copy thewhl
package.json
dev
line to build thewhl
just in time and place it in the same folder.Fix Github Actions to match
working-directory
are being modified in the early and deployment parts of the heat-stack Github Action file .Dockerfile
and.dockerignore
to.
which is currently./heat-stack
move it to the project root at https://github.com/codeforboston/home-energy-analysis-tool/blob/7fc77abacbe83f06da2d167e10d4caf7c2a1e9aa/.github/workflows/heat-stack.yml#L182-L183