search

codeforhuntsville / Frontier

A civic app for finding whats near me
http://codeforhuntsville.com/
MIT License
9 stars 7 forks source link

Added a bit of configuration checking in the default config. Adding … #30

Closed Nedlinin closed 9 years ago

Nedlinin commented 9 years ago

…it into default allows us to easily override the checks for production or development builds if desired (though I'm not sure we would ever actually want that..)

Right now the only check is for whether or not the Google Places API key appears to be supplied. We don't even check if the key is valid just that the parameter was supplied.

Removed the now unneccessary check of whether the key was supplied from the restaurants end point.

Fixes #20

Nedlinin commented 9 years ago

I should state that I haven't been to any of the meetings (yet) and don't know if we have a specific style guide or anything. But, I had a bit of spare time and sat down to look and figured I could at least knock this out relatively quickly.

chadxz commented 9 years ago

besides my one comment, this looks great! thanks Chris! If you can make that an early return i'll get this merged in :)

Nedlinin commented 9 years ago

@chadxz : :+1: Updated with the change.

chadxz commented 9 years ago

I tested this and it LGTM :+1: