Issue 11: Implement Frontend of Homepage

codeformilwaukee / DECARCERATION-PLATFORM

https://wisdp.com

GNU General Public License v3.0

18 stars 17 forks source link

Issue 11: Implement Frontend of Homepage #56

Closed rs6713 closed 4 years ago

rs6713 commented 4 years ago

Mainly altered Navigation and Homepage Components. Homepage view changes with respect to media size. On small screens (phone) navbar is animated dropdown. Centralised padding control to src/index.css, this makes it easier to sync nav and body padding depending on media size (can be overwritten on each page individuals css). Named Links on the main navigation bar, can be changed depending on the current page as specified in constants/navlinks.js

paul-rinaldi commented 4 years ago

@rs6713 do you think this is an issue with the footer component? Blue Sky Thinking (super optimistic) view of what should occur I think would be the Icons and their labels to resize as well. I will look into this for you! We might be able to use a grid to resize them.

rs6713 commented 4 years ago

@paul-rinaldi It was an issue with setting height instead of min-height for landing page, so in case of overflow, the area above the footer wasn't expanding, now should be fixed

rs6713 commented 4 years ago

Currently there is some media resizing in the css, which already functions for font-size etc in LandingPage.css, so also reducing the heights for example of icons on smaller screens should be fairly trivial

paul-rinaldi commented 4 years ago

Please fix all warnings (alt for images for accessibility and removing unused imports) before the PR can go through. I'll also note a few links to add to the 3 icons.

@rs6713