kenjis
commented
6 months ago Thank you for sending this PR!
We expect the following in all Pull Requests (PRs).
- All git commits must be GPG-signed
- Must follow our style guide
- Be commented in the PHP source file
- Be unit tested
- Pass all checks in GitHub Actions
[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.
If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.
See also the documentation in the main repository: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md
Description Huge performance improvement. config($class) seems to be an expensive process, and we don't really need it before falling back to the config property. Note: Try creating a for loop of 1000 to get a settings value