search

codeisland / codeisland.github.io

New home for Code Island projects
2 stars 4 forks source link

ASB Theme #21

Closed andrewborstein closed 9 years ago

andrewborstein commented 9 years ago

Hey guys. I piggy-backed on top of @goldenmeanie 's great work, including:

  1. Header Nav - new style, font-icons for social links, responsive menu toggle (with vanilla js and css only), png logo fallback for IE8
  2. 'Personality' - this is a buzzword we tossed around in the last meeting, and I contributed towards that end with some more color, i.e. color bands / sections on the home page
  3. Content - simplified and separated the home page into call-to-action sections and/or summaries. first section is a little more like a tagline or 9-second-sell. might want to add a 'projects' section in the future
  4. Next Meeting - added js script to display next meeting date, with link to view meetup
  5. 'Join' - I thought creating a 'join' page might be more inclusive than a 'members' page. also indicates that this is a living, breathing thing that's open to others' contribution

Let me know what you think.

goldenmeanie commented 9 years ago

Very nice! I this is a big step forward. Thank you for your work Andrew!

andrewborstein commented 9 years ago

Hey, @goldenmeanie.

This pull request is now ready for prime-time! Or at least for review.

UPDATES:

Let me know what you think.

goldenmeanie commented 9 years ago

Thanks @andrewborstein! I haven't had a chance to review this yet, but I will over the weekend. I appreciate your hard work on this, sorry to have been off the map for a couple weeks.

Frymasterspeck commented 9 years ago

I'm fine with incremental/iterative changes with updates and enhancements every few weeks, but this has some major changes, so I think we need to nail down at least the logo before we publish this.

And, for me, that's the only thing that's a must-have for this release. It's been a long time coming, so let's not postpone joy!

andrewborstein commented 9 years ago

@Frymasterspeck OK, great. Just to clarify — does "nailing down" the logo mean changing/improving the design or fixing something about the way it's implemented? For example, @goldenmeanie mentioned incorporating some SVG fallback stuff for the logo and/or all images. If it's something like that, I can help work on it.

Frymasterspeck commented 9 years ago

Design only.

andrewborstein commented 9 years ago

Hi guys. I won't be able to make it to Monday's meeting, but I wanted everyone and anyone to be able to easily review this website redesign before deciding to (potentially/eventually) merge the pull-request. So I forked the repo and created a github page to host it live.

Let me know if you have any questions. I'd love to hear feedback on the new design and features (full list here) from other members as well! Also testing for bugs would be great, especially the 'Next Meeting' section, since it displays information dynamically for each individual Meetup user.

jamesrhaley commented 9 years ago

The thing that is most important about Andrew's contribution is that it is responsive. While there might be disagreement on details of style or assets to be used, it works on phones which our current website does not. For decisions that have not yet been agreed upon, it would be easy to change colors, fonts, logo, and such to more reflect the older look. On the other hand it would take a lot more work to make the old design responsive so I say we move forward.

Great work Andrew.

James

On Sat, Feb 28, 2015 at 7:45 PM, Andrew Borstein notifications@github.com wrote:

Hi guys. I won't be able to make it to Monday's meeting, but I wanted everyone and anyone to be able to easily review this website redesign before deciding to (potentially/eventually) merge the pull-request. So I forked the repo https://github.com/andrewborstein/code-island.org/ and created a github page http://andrewborstein.github.io/code-island.org/ to host it live. Let me know if you have any questions. I'd love to hear feedback on the new design and features (full list here https://github.com/andrewborstein/code-island.org/#code-islandorg) from other members as well!

— Reply to this email directly or view it on GitHub https://github.com/codeisland/codeisland.github.io/pull/21#issuecomment-76563225 .

goldenmeanie commented 9 years ago

This is looking great Andrew!

andrewborstein commented 9 years ago

Thanks! I won't be at the meeting tomorrow but feel free to email if you have any questions.

andrewborstein commented 9 years ago

Awesome! Glad I could help.

goldenmeanie commented 9 years ago

You have been enormously helpful pushing this project (and others) forward. I'm sorry to hear we won't be seeing you as much over the next couple months, but congrats on the new opportunity!