search

codekitchen / dinghy-http-proxy

the http proxy container that dinghy uses
MIT License
125 stars 43 forks source link

Update go version to rebuild for M1/arm support #59

Closed taybenlor closed 2 years ago

taybenlor commented 3 years ago

I built a new version of this container because I was getting an error from go on my M1 (same as this one: https://github.com/FreedomBen/dory/issues/49#issuecomment-823991634). I looked at the nginx-proxy repo and they seemed to have ARM support. So I figured just a rebuild with docker would do it. To get it building against github.com/fsouza/go-dockerclient I needed to update golang to 1.16 and include a go.mod file. Those are the changes in this PR.

I hadn't build a multiplatform container before so I also followed these instructions for that. You can see the resulting container at taybenlor/dinghy-http-proxy:latest.

This seems to work for me as part of Dory but I don't use Dinghy.

far-blue commented 3 years ago

Any sign of getting this merged in? It would be great to see M1 support and if it's not in the codekitchen image everyone will end up moving to a fork which would be a shame

codekitchen commented 3 years ago

Sorry about that, I've been having trouble keeping up on this project since I don't use it myself anymore.

These changes look good. Unfortunately, I went into the docker hub settings to see how I might enable building the image for both architectures... and they now require a paid plan in order to do automated builds. It sounds like if I register as an open source project they may do it for free, so I'm filling out that application. I'd rather not have to change my build and release strategy at this point.

Alternatively: if Dory is still actively maintained, which it seems to be, maybe we should consider having Dory take over this image and repo.

paolomainardi commented 2 years ago

We started from this commit and created our own fork with github actions to build and push public docker images multiarch, you can find the repo here: https://github.com/sparkfabrik/dinghy-http-proxy and the images here: https://github.com/sparkfabrik/dinghy-http-proxy/pkgs/container/dinghy-http-proxy

chrishulton commented 2 years ago

I see there's been no activity on this issue for a couple months, nor the linked issue on Dory. Any luck in registering as an open source project? Similar to the other comments here we'd prefer not to fork and maintain our own copy of this repo just for the M1 support. Thanks.

codekitchen commented 2 years ago

I never heard back from Dory, or actually from Docker about the OSS project either. I'm just going to merge this and cut a release locally for now. Sorry for the huge delay.

codekitchen commented 2 years ago

OK version 2.7.0 released to Docker Hub

https://hub.docker.com/r/codekitchen/dinghy-http-proxy/tags?page=1&name=2.7.0

far-blue commented 2 years ago

Wonderful news, thank you :)

taybenlor commented 2 years ago

Thanks heaps!