codemix / babel-plugin-typecheck

Static and runtime type checking for JavaScript in the form of a Babel plugin.
MIT License
886 stars 44 forks source link

Still Maintained? #172

Closed taylor1791 closed 7 years ago

taylor1791 commented 8 years ago

I notice that some potentially serious issues have gone unanswered for a while. In addition, there hasn't been any recent new code. Finally, there are some pretty low hanging pull requests. All of this makes it appear as if the project is no longer maintained. If this is not true, can you give a description of your intentions for the future of this project?

gajus commented 8 years ago

It could be that the maintainer is on vacation or otherwise away from computer. His GitHub profile shows no/low activity in the past month, https://github.com/phpnode.

Which issues/PRs in particular are you referring to? I have merge rights, though I wouldn't be able to publish new NPM version.

If there are particular issues that babel-plugin-typecheck does not address, consider https://github.com/gcanti/babel-plugin-tcomb as an alternative. Mind you, I have not tested the latter, just came across it recently and noted its existence.

taylor1791 commented 8 years ago

Here are a few examples. #165 has been open for 22 days without a comment. #155 was the issue that particularly scared me. Looking at milestone 1 there are 5 issues marked as bugs going back as far as Jan 25. These are acknowledged bugs in the current implementation, plan to be fixed, but have yet been fixed. It is worth mentioning that 1 bug marked for the milestone was fixed. Also 1 low hanging MR was closed since I last looked by gajus.

I'll admit, I kinda sound like a jerk right now. Everyone that participates in open source deserves credit for the work they do. Thank you!

TamsynUlthara commented 7 years ago

It looks like @phpnode (the maintainer) is alive and well, and working on a new project:

But yeah, it would be nice to get confirmation as to whether this project is still maintained or being orphaned; I'm in the middle of evaluating static type libraries, and I tend to shy away from anything without active development.

phpnode commented 7 years ago

Hey, yeah sorry for the lack of updates on this, I've badly neglected this project for too long and I'm really sorry about that - other things in life took over. The last few weeks I've been working on flow-runtime which will deprecate this project, it does everything that babel-plugin-typecheck does but uses a runtime library and aims for full flow compatibility which was not possible with the previous approach. I'm still working on the docs site but hope to do a release very soon.

gajus commented 7 years ago

@phpnode glad to see you are Okay.

On the subject of flow-runtime, is there a reason for duplicating the effort with https://github.com/gcanti/babel-plugin-tcomb. As far as I can tell, both strive for full compatibility with Flow type.

phpnode commented 7 years ago

@gajus I raised this very issue with @gcanti about this here - https://github.com/gcanti/flow-io/issues/19 - tl;dr - babel-plugin-tcomb ran into the same issues as babel-plugin-typecheck - it's very hard to coexist with flow if you don't support absolutely everything flow does, and total flow compat is not a goal of tcomb (or now flow-io). I really do hope we can bring the projects together eventually because they are so similar.

phpnode commented 7 years ago

Ok I just published the first (hopefully) usable version of flow-runtime and put together a docs site with some examples here - https://codemix.github.io/flow-runtime/ I'll go through the issues in this repo and transfer any applicable ones over to https://github.com/codemix/flow-runtime and deprecate this project.

TamsynUlthara commented 7 years ago

@phpnode Thanks! I was just about to start playing with flow-runtime and had to npm-link a checkout (since package.json dependencies don't support Git subfolder URLs, so no monorepos), but a published version will make it easier.

taylor1791 commented 7 years ago

Thanks for giving everyone an update! I am excited to checkout flow-runtime! I think this issue has been settled.