search

coder / sshcode

Run VS Code on any server over SSH.
MIT License
5.74k stars 216 forks source link

Ctrl-J in extensions view opens up Chrome downloads page instead of VSCode terminal #151

Open samuela opened 4 years ago

samuela commented 4 years ago

Title really says it all. A lot of the time when I hit Ctrl-J, it ends up opening the Chrome "Downloads" page instead of toggling the VSCode terminal on/off.

Merith-TK commented 4 years ago

Yeah due to the nature of the software, thare are some keybinds that cant be controlled, also i feel as if this is a issue for normal Code-Server as this has to deal with code-server and NOT sshcode

EDIT: the default keymap for opening the terminal is CTRL+SHIFT+~

samuela commented 4 years ago

Oh, that's right. Ctrl-J is toggles the bottom bar thingy, but not the terminal per se.

Merith-TK commented 4 years ago

Also i cannot reproduce this

samuela commented 4 years ago

I'm running Chromium 74.0.3729.157 (Official Build) Built on Raspbian , running on Raspbian 10 (32-bit). sshcode installed via go get -u go.coder.com/sshcode.

Maybe it's a Chrome vs Chromium issue? I should also point out that it doesn't occur every time... There are certain scenarios in which Ctrl-J works just as expected and others where it opens up the Downloads page.

Merith-TK commented 4 years ago

Hmm, not really, I use brave with no issue, but it might be the fact that you are using a Pi?

samuela commented 4 years ago

Possibly, I'd imagine it has to do with how the browser shim propagates keyboard events but I can't be sure of that.

Merith-TK commented 4 years ago

Unsure as well. But definitely something to look into a bit

On Tue, Nov 26, 2019, 12:41 PM samuela notifications@github.com wrote:

Possibly, I'd imagine it has to do with how the browser shim propagates keyboard events but I can't be sure of that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cdr/sshcode/issues/151?email_source=notifications&email_token=ACPQOXUBRXSNIGRWROW4RG3QVWCYRA5CNFSM4JQ6ELY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHL4OI#issuecomment-558808633, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXXVDFENVDT6AB6BP6TQVWCYRANCNFSM4JQ6ELYQ .