search

coderaiser / smalltalk

Promise-based Alert, Confirm and Prompt replacement
MIT License
91 stars 20 forks source link

Add custom label buttons and test #15

Closed paologf closed 6 years ago

paologf commented 6 years ago

I put buttons label into options like {'buttons': {'ok':'Ok Label','cancel':'Cancel Label'}}.

I had an issue into test comparing html template : the one loaded from file system have a "newline" that I'm not able to find and remove using text editor (vi, vim, oni, atom..). My solution was add a function that remove the new line before comparing html.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4eda6a0a6ce8c8248537819ba49e722f8ed0328a on paologf:ButtonsLabel into a721d2ba4feb4a54f6c5897ada665b7630d736c0 on coderaiser:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4eda6a0a6ce8c8248537819ba49e722f8ed0328a on paologf:ButtonsLabel into a721d2ba4feb4a54f6c5897ada665b7630d736c0 on coderaiser:master.

coderaiser commented 6 years ago

Thank you :), merged as 6cf7fc67. Landed in v3.1.0