search

coderaiser / smalltalk

Promise-based Alert, Confirm and Prompt replacement
MIT License
91 stars 20 forks source link

Remove global font setting for buttons (fix #32) #33

Open pjeby opened 2 years ago

coderaiser commented 2 years ago

I think better to put this style under .smalltalk button

pjeby commented 2 years ago

But then people will still have to override it to specify the font-family they want buttons to normally have, so that the buttons will by default match their global styling. Better to fall back to the application's fonts, to ensure compatibility with any i18n/a11y issues for fonts. (A library should really not be setting font families in required CSS, unless it's to use a specialized font like an icon library -- everyone will just end up having to override it with more-specific selectors, adding unnecessary overhead.)

coderaiser commented 2 years ago

In this case, would be great to check styles of Cloud Commander and make changes if needed, so everything worked as it was before modification.

Anyways you can always use !important keyword.