search

coderifous / jquery-localize

a jQuery plugin that makes it easy to internationalize your web site.
465 stars 142 forks source link

Added HTML5 placeholder support #4

Closed grandecomplex closed 13 years ago

grandecomplex commented 13 years ago

I am making the assumption that if the author has added placeholder="" to the input tag they want that localized rather than the value.

coderifous commented 13 years ago

Hey grandecomplex,

I'd like to pull this in, but a few things first:

1) add a test for the placeholder handling in basic_usage.html

2) All of my code uses spaces only, no tabs allowed. See how the indentation of your code isn't correct here: https://github.com/grandecomplex/jquery-localize/blob/master/src/jquery.localize.js#L62 Please fix the indentation using spaces instead of tabs.

3) Squash all of your commits into a single commit. If you haven't used git rebase -i ... before, then this will be a great chance to learn about a wonderful feature of git. You'll want to "squash" all of your related commits into one, so everybody will just see one commit in the history: "Added HTML5 placeholder support".

If you have any q's just ask :)

Thanks, Jim

grandecomplex commented 13 years ago

Your attention to detailed is appreciated. I'll do this sometime before the weekend.