Open Aryamanz29 opened 3 years ago
Hi,
Is there any specific question that has to be solved by these algorithms or just the code for how these algorithms are performed has to be submitted? I am new to Hacktoberfest, any help would be appreciated.
@iriyagupta according to this issue you have to implement DFS and BFS using python.
Your code should be written in the modular way so that it can be used as a method of a package.
Before contributing you must read this to know about how a package is made.
After this you can make a separate file as dsalgo/graphs.py
and start writing code for above mentioned algorithms. Also don't forget to write test cases for your code in tests/
.
Happy Coding :relaxed:
Is this issue open? Can i work on this issue?
@Pratik-ahirrao you are already assigned to an issue. Resolve it first
@Aryamanz29 Two questions, which one to use Adjacency List or Adjacency Matrix for graph input? These functions (BFS and DFS) should run on both directed and undirected graphs if that's the case how do you want to handle input in this case?
@rootaux we want to develop a library so that users can get what they want easily. If all the changes you want to suggest are related, then I would suggest using a single file for that
@devkapilbansal I was just asking how do you want to handle directed and undirected graphs. Should it be passed as an argument?
bfs(graph, isDirected)
or a different function altogether
directed_bfs(graph)
undirected_bfs(graph)
@rootaux this approach would be better
bfs(graph, isDirected)
@devkapilbansal On second thought I did not implemented it in the way I said earlier. I figured since the input will be given by the user, it will be up-to him if the graph is directed or not.
May be adding this would be beneficial