search

codesuki / ecs-nginx-proxy

Reverse proxy for AWS ECS. Lets you address your docker containers by sub domain.
MIT License
98 stars 23 forks source link

Updated Nginx Docker Image to alpine version #4

Closed Madhu1512 closed 7 years ago

Madhu1512 commented 7 years ago

This PR updates is to add Nginx alpine docker image instead of Nginx jessie image. This will reduce the docker image size to half.

codesuki commented 7 years ago

Thanks for your pull request. It is certainly a good idea to reduce the docker image size. But maybe this should be a separate docker file so people can choose which release they use. Apart from that some changes in your pull request seem to have broken the thing. By adding ["nginx", "-g", "daemon off;"] nginx becomes blocking and the ecs-gen command does not run. Also I am not sure you can use the [] syntax together with the shell syntax, but I can't say that for sure.

Madhu1512 commented 7 years ago

Agreed. Let me make the changes and submit another pull request