Wrong syntax highlighting for Groovy GStrings when interpolating values

codewars / runner

Issue tracker for Code Runner

34 stars 8 forks source link

Wrong syntax highlighting for Groovy GStrings when interpolating values #318

Open FranzMartyn opened 2 months ago

FranzMartyn commented 2 months ago

Describe the bug Sometimes, codewars' code runner gets the syntax highlighting for GStrings wrong when they contain interpolated values

Code runner does this:

Expected behavior

instead of this (example from Intellij Idea):

To Reproduce

Create a Kumite in Groovy
Create variables and interpolate them into a String

Kumite: https://www.codewars.com/kumite/66cc60e3d8acf6782ef5515c

Browser

OS: Windows 10 Pro, Version 22H2, Build 19045.4780
Browser: Chrome
Version: 128.0.6613.84 (Official Build) (64-Bit)

hobovsky commented 2 months ago

IIRC, syntax highlighting is done with capabilities of the CodeMirror 5 editor, and Codewars does not have any special control over it. Ideally this problem would be resolved by submitting a PR to CodeMirror, so Codewars could later use the fixed version.

Problematic part can be that CW uses CodeMirror 5, which is not the latest version. I do not know if it still accepts fixes and improvements.

FranzMartyn commented 2 months ago

Are there any plans on updating to a later version of CodeMirror or is there no need for it?

hobovsky commented 2 months ago

I am not aware of any.

FranzMartyn commented 2 months ago

Seems like it's fixes now

https://github.com/codemirror/legacy-modes/commit/2675b58e4a29dd2a0012c0cc2039dbe96bcc1070

hobovsky commented 2 months ago

I will check what has to be done to make sure that CW uses the fixed mode.