search

codewithnick / ascii-art

A C++ library to make everyday alphabets look much better on the terminal , this project uses OOPS concepts to make unique fonts and display letters on command line
MIT License
71 stars 138 forks source link

D to block #1136

Closed nakul-py closed 1 month ago

nakul-py commented 1 month ago

added d character to block.

image

closes #1123

codewithnick commented 1 month ago

Hi @nakul-py thanks for trying this out there are a few problems with your pr, 1) you need to make changes only where required (not in example.cpp) 2) this pr must be done with only one commit 3) if you are solving an issue for 'd' do it only for 'd' don't add other letters, you can always open new issues and pr's if you want to add other letters. 4) you do not have updated version of the main repository(your fork is outdated) you need to sync changes using git fetch upstream or a similar command.

I am assuming you are a beginner, so take this opportunity to learn how to squash commits and force updated commits to your existing pr's if you are unable to do so you can also close this pull request and open a new one for the same issue keeping above points in mind.

This goes same for all the other prs you have made.

nakul-py commented 1 month ago

added d character to block.

Screenshot from 2024-10-08 17-38-19

closes https://github.com/codewithnick/ascii-art/issues/1123

codewithnick commented 1 month ago

the problems are still there look at the commits section there are 14 commits, look at file changes you only need to change 'd' not other letters.