codicocodes / dotfyle

Find the best Neovim plugins
https://dotfyle.com
MIT License
762 stars 32 forks source link

feat(user): Delete Configuration #150

Closed uroybd closed 1 week ago

uroybd commented 2 months ago

This PR allows the user to mark a config for deletion in the next sync.

The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.

This is my first time working with Svelte and TRPC so feel free to criticise as much as you like.

This PR has some hiccups we may want to address first:

codicocodes commented 2 months ago

The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.

Interesting consideration! I think it's OK to not consider this for now though, and if we see it being an issue we can add a rate limit when adding a config.

uroybd commented 2 months ago

The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.

Interesting consideration! I think it's OK to not consider this for now though, and if we see it being an issue we can add a rate limit when adding a config.

I've simplified things as you recommended.

uroybd commented 2 months ago

@codicocodes please let me know if any changes are required.

dfgordon commented 1 month ago

This is to call attention to an issue that this PR should fix, but might not. If you have a config and a plugin pointing to the same repository, only one will receive updated statistics (in my case star count has been out of sync for many days). Deleting one or the other is presumably the solution. However there could be some forms of update logic that would not respond in the expected way to a deletion in this scenario. Whether that is the case here I don't know, just pointing out the possibility.

codicocodes commented 1 week ago

This is to call attention to an issue that this PR should fix, but might not. If you have a config and a plugin pointing to the same repository, only one will receive updated statistics (in my case star count has been out of sync for many days). Deleting one or the other is presumably the solution. However there could be some forms of update logic that would not respond in the expected way to a deletion in this scenario. Whether that is the case here I don't know, just pointing out the possibility.

You shouldn't have the same repository pointing to both a config and a plugin.

Plugins are only synced once a week, that's likely why you're reporting mismatch in stars.