coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Code Coverage >50 % #80

Closed aggarwalpulkit596 closed 6 years ago

aggarwalpulkit596 commented 6 years ago

screen shot 2018-05-19 at 5 32 44 pm https://github.com/coding-blocks/DigitalOceanApp/issues/59

aggarwalpulkit596 commented 6 years ago

@championswimmer bhaiya codecliate is showing error for variable declartion and import statements again again do i need to fix it ?

championswimmer commented 6 years ago

Ignore codeclimate stuff for now

aggarwalpulkit596 commented 6 years ago

@championswimmer okay bhaiya Kindly check the pull request regarding the code coverage issue

championswimmer commented 6 years ago

Some errors on Travis still

in.tosc.digitaloceanapp.activities.DropletActivityTest > testDropletInfo[test(AVD) - 5.0.2] FAILED 
    android.support.test.espresso.PerformException: Error performing 'single click' on view 'with text: is "Settings"'.
    at android.support.test.espresso.PerformException$Builder.build(PerformException.java:82)
:app:connectedDebugAndroidTest FAILED
aggarwalpulkit596 commented 6 years ago

Will fix that in a moment

aggarwalpulkit596 commented 6 years ago

there was some lines of codes which have been removed by a recent commit creating that Travis error which i have fixed with rebasing

codecov[bot] commented 6 years ago

Codecov Report

Merging #80 into master will increase coverage by 13.85%. The diff coverage is 85.71%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #80       +/-   ##
=============================================
+ Coverage     13.54%   27.39%   +13.85%     
- Complexity       16       33       +17     
=============================================
  Files            15       83       +68     
  Lines           805     1865     +1060     
  Branches         70       91       +21     
=============================================
+ Hits            109      511      +402     
- Misses          687     1319      +632     
- Partials          9       35       +26
Impacted Files Coverage Δ Complexity Δ
...tosc/digitaloceanapp/activities/AboutActivity.java 86.66% <ø> (+55.08%) 0 <0> (-2) :arrow_down:
...italoceanapp/activities/DetailDropletActivity.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...osc/digitaloceanapp/activities/SplashActivity.java 21.56% <ø> (+21.56%) 0 <0> (ø) :arrow_down:
...java/in/tosc/doandroidlib/api/DOLoginActivity.java 0% <0%> (ø) 0 <0> (?)
.../tosc/digitaloceanapp/activities/TestActivity.java 100% <100%> (ø) 2 <2> (?)
...in/java/in/tosc/doandroidlib/common/ApiAction.java 0% <0%> (ø) 0% <0%> (?)
...in/java/in/tosc/doandroidlib/common/ImageType.java 50% <0%> (ø) 2% <0%> (?)
...java/in/tosc/doandroidlib/objects/AccountInfo.java 40% <0%> (ø) 2% <0%> (?)
.../java/in/tosc/doandroidlib/objects/Statistics.java 0% <0%> (ø) 0% <0%> (?)
...main/java/in/tosc/doandroidlib/objects/Images.java 0% <0%> (ø) 0% <0%> (?)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ef9d9e...9c7bad3. Read the comment docs.