coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Data Binding to Activities #98

Closed aggarwalpulkit596 closed 6 years ago

aggarwalpulkit596 commented 6 years ago

Fix for #72

codecov[bot] commented 6 years ago

Codecov Report

Merging #98 into master will decrease coverage by 0.92%. The diff coverage is 15.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     27.51%   26.58%   -0.93%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1872     1877       +5     
  Branches         94       90       -4     
============================================
- Hits            515      499      -16     
- Misses         1320     1342      +22     
+ Partials         37       36       -1
Impacted Files Coverage Δ Complexity Δ
...tosc/digitaloceanapp/activities/AboutActivity.java 86.66% <ø> (ø) 0 <0> (ø) :arrow_down:
...italoceanapp/activities/DetailDropletActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...italoceanapp/activities/DropletCreateActivity.java 38.8% <14.28%> (-2.63%) 0 <0> (ø)
...sc/digitaloceanapp/activities/DropletActivity.java 64.22% <69.56%> (-1.36%) 0 <0> (ø)
...osc/digitaloceanapp/activities/SplashActivity.java 16.66% <75%> (-4.91%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1b1036...9c3f246. Read the comment docs.

aggarwalpulkit596 commented 6 years ago

@championswimmer kindly review this pr and codeclimate errors are for having the same line of code in 2 3 places but in actual they are different lines of code which cannot be refactored and also the conflict has also been resolved