"Make sure to check the "Share audio" box in Google Chrome" on Chrome/Firefox ends stream when audio streaming enabled

codysherman / 2nfm

Share your screen and computer's audio via WebRTC!

https://2n.fm

BSD 3-Clause "New" or "Revised" License

31 stars 16 forks source link

"Make sure to check the "Share audio" box in Google Chrome" on Chrome/Firefox ends stream when audio streaming enabled #234

Open jacksongoode opened 2 years ago

jacksongoode commented 2 years ago

There's seems either to be a bug or limitation with the current interface. Once a window is selected from FF or Chrome with audio sharing enabled, the stream will end once the notice is "Ok"-ed. I believe the proper permissions were enabled for the site.

codysherman commented 2 years ago

Backend went down earlier today (or a few days ago at somepoint. Was noticed today), should be back online now. Can you double check the bug still exists?

Clarifying questions: What OS are you on? When you say share "window" do you literally mean window? VS Tab or Desktop?

jacksongoode commented 2 years ago

Fedora 35, and yes, literal window. Still an issue.

codysherman commented 2 years ago

In the past sharing window audio wasn't supported from any OS, I'm surprised it let check the box. You see a checkbox in the corner of the pop-up that says "Share audio" like exits on share tab screen? See my attached screenshots, the checkbox in bottom left should disappear. However I'm on Chrome OS. I'll try on my Fedora machine! Thanks so much for reporting the bug btw!

Screenshot 2021-10-25 3 29 17 PM

Screenshot 2021-10-25 3 29 41 PM

jacksongoode commented 2 years ago

Ah, yes the "Share system audio" checkbox doesn't appear anywhere on the sharing screen. Using Chromium | 95.0.4638.54 (Official Build, ungoogled-chromium) (64-bit) Flatpak version.

codysherman commented 2 years ago

Ya, so unfortunately as of last time I checked, I can't affect which options are shown. Ideally, when you pick an option that includes audio, I'd hide the ability to pick "window", but that just doesn't exist yet. So there isn't much I can do other than improve the error message and make it clearer.