coforma / swift-tech-challenge

MIT License
0 stars 0 forks source link

Expose data object in provider alongside array #151

Closed braxex closed 5 months ago

braxex commented 5 months ago

Summary

We need the institutions data available in both array and object form. This PR converts the array results to an object (indexed by institution id) and stores them alongside the array results in the provider.

Type of change

How To Test

Pull it down and use it

Checklist

codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit e33b8302 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 56.2% (80% is the threshold).

This pull request will bring the total coverage in the repository to 87.3% (-0.4% change).

View more on Code Climate.

braxex commented 5 months ago

@gmrabian Yeah i ran the same tests. Obviously depends on which item you're querying (for the array.filter) but still it's not much. I don't think the context load should give you any trouble though since it's just sitting there. Let's chat and figure it out.