cog-imperial / entmoot

Multiobjective black-box optimization using gradient-boosted trees
https://entmoot.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
56 stars 12 forks source link

Incorrect and inconsistent tests in pipeline #38

Closed TobyBoyne closed 3 months ago

TobyBoyne commented 3 months ago

We should review the tests that we are including in the pipeline. For example, the test below asserts that the proposed point is $x^* \in [-0.5, 0.5]$. However, it is unclear to me that this is correct in the exploration setting. Indeed, when using the gurobi_direct interface for Pyomo, this test sometimes fails.

Further, we should consider using random seeds in the testing to ensure that tests are reproducible.

https://github.com/cog-imperial/entmoot/blob/5d7003daadc2c23312df2b5ba8c746dc3de5e840/tests/test_curr.py#L116-L129