search

cognitect-labs / test-runner

A test runner for clojure.test
Eclipse Public License 2.0
287 stars 31 forks source link

Run shutdown-agents after tests complete #3

Closed enaeher closed 6 years ago

enaeher commented 6 years ago

This prevents a delay between reporting test results and exiting the process, if any tests have left thread pools running.

levand commented 6 years ago

Hey @enaeher, thanks a ton for the PR!

After talking with some folks at work, because this is a repo hosted in a Cognitect account, they'd like for all contributors to have signed the Cognitect Contributor's Agreement, which basically assigns us full copyright of your contribution. You can sign it online at https://secure.echosign.com/public/hostedForm?formid=8JU33Z7A7JX84U.

If you've already signed the CCA, great, I'll just accept this PR. If not, you can either sign it, or if it's not worth it to you for such a small PR I can just close this and re-implement this myself.

Sorry about the complication!

enaeher commented 6 years ago

@levand no problem, I've gone ahead and signed it.