search

coin3d / coin

Coin3D core library
BSD 3-Clause "New" or "Revised" License
275 stars 106 forks source link

SoLight again (3.1.2 vs 3.1.3) #92

Closed VolkerEnderlein closed 9 years ago

VolkerEnderlein commented 9 years ago

Original report by Anonymous.

Attachments: coin3d.png | Hercule_AC130.3ds | Hercules - Rendered.png | Hercules - Translated & Rendered.png

And the phong effect doesn't look to be OK (see PNG file)

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

The problem could be with the code or it could be your scene graph. If you can attach your scene graph file I would be happy to help further and we can identify the problem.

In fact, make it simpler, substitute all your aircraft model details for a two cubes. Assign the same material properties as, say the fuselage and the cockpit to the cubes. Then we have a nice simple test file. Attach that rather than the full model.

Roy

VolkerEnderlein commented 9 years ago

Original comment by AUBINEAU Franck (Bitbucket: lefau, ).

I'm using a 3ds file ... but I don't know how to attach it here !

VolkerEnderlein commented 9 years ago

Original comment by AUBINEAU Franck (Bitbucket: lefau, ).

I find ;-)

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Franck,

Thanks for your attachment. I know that Coin should be able to import 3DS files but I am not sure how robust it is. I'll have a little play and get back to you.

Roy

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Franck,

I persuaded my software to load your file! It is based on Coin4, i.e. the current repository. As you can see, it is worse than yours! This has got to be down to the fact that it is a 3DS file.

Is there any other way you can convert the 3DS file into either Inventor or VRML and then load it with your Coin application?

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Franck,

I used Blender to import the 3DS file and then export it to X3D. I then used my development X3D implementation to load the file. The result (after I turned the headlight on!) is attached.

Roy

VolkerEnderlein commented 9 years ago

Original comment by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

I just loaded the 3ds airplane model with the latest development version (Coin 4) and it looks fine. This scene used a SoDirectionalLight and SoOrthographicCamera node before the graph, which has been loaded from the attached 3ds file:

Screen Shot 2015-01-21 at 9.05.53 PM.png

Roy, it seems your software doesn't have the fix for issue #67 yet.

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Thomas,

You're absolutely right. That's the problem with maintaining two code bases!! I've implemented the fix and now my picture looks just like yours. Many thanks.

Franck

For your reference the fix for my bad graphic is in pull request #197.

Roy

VolkerEnderlein commented 9 years ago

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

Can this be closed with pull request #197?

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

I don't see why not.

VolkerEnderlein commented 9 years ago

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

Fixed with pull request #197. This was a 3DS import issue, rather than SoLight directly.