search

collective / buildout.plonetest

Testing/development buildouts for Plone
6 stars 12 forks source link

Pin isort = 4.3.20 for Python 2 #69

Closed idgserpro closed 4 years ago

idgserpro commented 4 years ago

Newest versions aren't compatible with Python 2 See:

https://github.com/timothycrosley/isort/blob/2952db41650211984fe64ac0b856881627e55aeb/pyproject.toml#L27

idgserpro commented 4 years ago

I had seen that 4.3.21 tag wasn't compatible with Python 2:

https://github.com/timothycrosley/isort/blob/4.3.21/setup.py#L42

But it looks like this was fixed in 4.3.21-2 tag:

https://github.com/timothycrosley/isort/blob/4.3.21-2/setup.py#L43

I tested version 4.3.21 of pypi and it worked.

I made the change here.

mauritsvanrees commented 4 years ago

Merged, thanks.