search

collective / collective.ckeditor

4 stars 20 forks source link

Use pat-ckeditor #78

Open thet opened 2 years ago

thet commented 2 years ago

Hi @duchenean - as we were chatting today on the way to the namur train station, you might consider using pat-ckeditor: https://github.com/Patternslib/pat-ckeditor

for an example how to add options via a data-pat-ckeditor attribute, see the example at https://github.com/Patternslib/pat-PATTERN_TEMPLATE/blob/master/src/PATTERN_TEMPLATE.js

You can then open a PR at https://github.com/Patternslib/pat-ckeditor

thet commented 2 years ago

Just released 3.2.0, which would be the version to use.

However, in Plone 6 it should even be easier to include any JavaScript in Plone.

But the benefit with this pattern would be that you don't have any bundling stuff in this package, only integration of the Pattern + the JavaScript would only be loaded when the pattern is used.

gotcha commented 2 years ago

It is great that there is a patternlib integration. Nevertheless, I see it is CKEditor 5 and some people have plugins for CKEditor 4.

I guess it might make sense to start with the current code.