search

collective / collective.externaleditor

A specific Plone layer for Products.ExternalEditor
0 stars 3 forks source link

When calling externalEditorEnabled, this is the view that's called and no more the script #4

Open sgeulette opened 8 years ago

sgeulette commented 8 years ago

Using Plone 4.3.9 ext_edit action has the condition object/externalEditorEnabled. Calling externalEditorEnabled returns the view = always True !! The script skins/externaleditor/externalEditorEnabled.py containing return context.restrictedTraverse('@@externalEditorEnabled').available() is no more called. From which version of plone, views calls have priority to scripts ?

I can propose a pull request managing call using available method and just calling view in script

sgeulette commented 8 years ago

See pull request #5

sgeulette commented 8 years ago

@mattss @gforcada @pbauer hello, someone to comment, review pull request, merge. Thks

mattss commented 8 years ago

I'm not clear on the history of this package - I only recently made some small fixes to fix incompatibilities with later Plone versions.

AFAIK skin scripts still trump browser views, so I'm not convinced this change will have any affect. If we want to use the browser view exclusively, we should also remove the skin script version, but I can't speak to the fallout of that change.