Document how to access the documentation in the browser

collective / icalendar

icalendar parser library for Python

https://icalendar.readthedocs.io

Other

1k stars 172 forks source link

Document how to access the documentation in the browser #625

Closed niccokunzmann closed 5 months ago

niccokunzmann commented 5 months ago

This is a nice add-on for maintainers.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9419565914

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.706%

Totals
Change from base Build 9241523599:	0.0%
Covered Lines:	2760
Relevant Lines:	2854

💛 - Coveralls

stevepiercy commented 5 months ago

Oh, it needs a change log entry.

niccokunzmann commented 5 months ago

I logged the changes.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9447279411

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.706%

Totals
Change from base Build 9241523599:	0.0%
Covered Lines:	2760
Relevant Lines:	2854

💛 - Coveralls

stevepiercy commented 5 months ago

Merge away!

niccokunzmann commented 5 months ago

@stevepiercy Do you have merge access? You would probably count as a collaborator: https://icalendar.readthedocs.io/en/latest/maintenance.html#collaborators What do you think?

stevepiercy commented 5 months ago

@niccokunzmann I'm a member of Collective, so I have write access and can merge PRs. I am still getting familiar with this library, but I have confidence with docs only to merge those PRs in the future.

As a side note, Collective is a very trusting organization, and it might be a good idea to restrict write access to only core contributors and other trustworthy folks for this one repository. Plone recently did that for its organization, mostly due to GSoC applicants doing bad things, like editing PLIPs. It also reduced risk if an unused or inactive account were to become compromised.