search

collective / icalendar

icalendar parser library for Python
https://icalendar.readthedocs.io
Other
1k stars 172 forks source link

Support python 3.13 #729

Closed Firdous2307 closed 1 month ago

Firdous2307 commented 1 month ago

Add support for Python 3.13

This PR adds support for Python 3.13 to the icalendar project. It includes updates to the test configurations, project metadata, and documentation.

Changes made:

  1. Added Python 3.13 to the GitHub Actions test matrix
  2. Included py313 environment in tox configuration
  3. Updated classifiers in pyproject.toml to include Python 3.13
  4. Updated README with Python 3.13 compatibility information
  5. Added documentation on the process of updating Python versions

Documentation:

This PR addresses issue #723.

📚 Documentation preview 📚: https://icalendar--729.org.readthedocs.build/

niccokunzmann commented 1 month ago

@Firdous2307 Thanks! I wonder why there are no merge conflicts.. I will update the branch.

Could you fix the changelog? The last change was in the already released version. Thanks for the documentation!

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11364486897

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 11317448813: 0.01%
Covered Lines: 3520
Relevant Lines: 3612
💛 - Coveralls
Firdous2307 commented 1 month ago

@niccokunzmann no problem , I have fixed the changelog

niccokunzmann commented 1 month ago

Thanks for working on it! It is nice for me to collaborate instead of doing it myself! I hope I learn to be better at communicating this way, too :)

niccokunzmann commented 1 month ago

Please let me know when you would like me to review/merge!

Firdous2307 commented 1 month ago

Thanks for working on it! It is nice for me to collaborate instead of doing it myself! I hope I learn to be better at communicating this way, too :)

Thank you! Glad you're enjoying the collaboration. You're doing great, and it only gets better with practice! 😊

Firdous2307 commented 1 month ago

@niccokunzmann It's ready for review!!

Firdous2307 commented 1 month ago

@niccokunzmann It's ready for review!!

niccokunzmann commented 1 month ago

Please have a look at the changelog file https://github.com/collective/icalendar/blob/30197304a45053dc4cb31e279b992cb45c46d5e1/CHANGES.rst You can view this file and you will see inconsistencies at the start.

your changes should be added to the top heading:

https://github.com/collective/icalendar/blob/main/CHANGES.rst

Everything else would be left untouched - except for the change for 3.13 that landed in the wrong release.

niccokunzmann commented 1 month ago

Hm... No problem if you want to not spend so much time just on the changelog... I create a PR for you ....

niccokunzmann commented 1 month ago

I could not create a PR but I could commit directly.

I think, https://github.com/collective/icalendar/pull/730#discussion_r1798599889 is valid for this PR, though, could you use the proper RST way and then, I think, it is fine to merge!

stevepiercy commented 1 month ago

The changes in this PR do not do what the description says.

niccokunzmann commented 1 month ago

@stevepiercy I think that is ok. @Firdous2307 is contributing for the first time and it does not need to be too perfect. This is a follow-up PR from the on made already to close #723. In that sense, it is not too bad. We had the changes in here but they were removed because of duplication.

Firdous2307 commented 1 month ago

@niccokunzmann Any more changes needed to make?

Firdous2307 commented 1 month ago

I will apply these changes and merge it. Thanks!

@niccokunzmann You are welcome, had a fun experience working on this issue

niccokunzmann commented 1 month ago

@Firdous2307 Thanks for your work!

I squashed the commits into one and so you will need to start from collective/icalendar's main branch for new PRs.

niccokunzmann commented 1 month ago

If you are doing the hacvktoberfest, have a look if this shows up as a contribution - it should. If it does not , let me know :)

Firdous2307 commented 1 month ago

If you are doing the hacvktoberfest, have a look if this shows up as a contribution - it should. If it does not , let me know :)

@niccokunzmann Yes I am, ideally it shows up as a contribution but they review it in 7 days. I will keep you posted on it.