fix: explicitly stage transaction to correctly run afterCommit jobs

colopl / laravel-spanner

Laravel database driver for Google Cloud Spanner

Apache License 2.0

97 stars 16 forks source link

Closed oprudkyi closed 1 year ago

oprudkyi commented 1 year ago

Laravel v10.32.0 requires explicit staging/clearing of transactions https://github.com/laravel/framework/pull/48859 without this code afterCommit jobs are never sent

Fix: #

taka-oyama commented 1 year ago

Hi, thank you for submitting the fix.

May I ask you to do the following.

Add the fix to CHANGELOG
Change the composer.json dependency for laravel/framework from ^10.0 to ^10.32.0.

Thanks!

taka-oyama commented 1 year ago

[Note to self] This needs to be back ported to v5 and be released as v5.3.0

oprudkyi commented 1 year ago

Hi @taka-oyama

done. please check

taka-oyama commented 1 year ago

Thanks for the PR. This has been released as v5.3.0.