search

color-js / elements

WIP
14 stars 1 forks source link

[channel-slider] Don't throw on unknown channels when working with `defaultValue` #46

Closed DmitrySharabin closed 5 months ago

DmitrySharabin commented 6 months ago

We face this issue when we try to set space programmatically (e.g., in <color-picker>).

netlify[bot] commented 6 months ago

Deploy Preview for color-elements ready!

Name Link
Latest commit 180178bc2eb7e6b177f9f50508fb3b2eb4c8a794
Latest deploy log https://app.netlify.com/sites/color-elements/deploys/664b342ffb33b00008b20d84
Deploy Preview https://deploy-preview-46--color-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin commented 6 months ago

<color-picker> works correctly (after merging #47) even if this PR is not merged. The only thing that might be a bit annoying is that we have errors in the console when setting space on <color-picker> programmatically.

image
DmitrySharabin commented 5 months ago

Nah. Let's not merge it if it's not good enough. We'll find a better solution. :)