App Crash with invalid URL submitted

colyseus / proxy

🔀⚔ Proxy and Service Discovery for Colyseus 0.10 ~ 0.14 (Not recommended on 0.15+)

https://docs.colyseus.io/scalability/

MIT License

37 stars 25 forks source link

App Crash with invalid URL submitted #37

Open hunkydoryrepair opened 7 months ago

hunkydoryrepair commented 7 months ago

A malicious user can send an invalid URL in the HTTP header and the proxy throws an unhandled exception, killing the process and disconnecting all active sockets.

Can be trivially fixed with try/catch in the request and upgrade handlers.