comet-ml / opik

Open-source end-to-end LLM Development Platform
Apache License 2.0
2.29k stars 141 forks source link

NO-JIRA: Updated Python SDK fern autogenerated code #700

Closed andrescrz closed 6 days ago

andrescrz commented 1 week ago

Details

I run the following script:

./scripts/generate_openapi.sh

So sdks/python/code_generation/fern/openapi/openapi.yaml was updated with the latest backend API, so all Python SDK Fern autogenerated code was updated under sdks/python/src/opik/rest_api/ folder.

Triggering the backend build also caused Java code to be formatted with Spotless.

Issues

N/A

Testing

Documentation

N/A

andrescrz commented 1 week ago

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

thiagohora commented 1 week ago

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

Yeah, I mean for Java, since many of your changes in Java were formatting. Anyway, it's approved.

alexkuzmik commented 1 week ago

Please update the readme in code_generation so that everybody know we now have this script

andrescrz commented 1 week ago

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

Yeah, I mean for Java, since many of your changes in Java were formatting. Anyway, it's approved.

That makes sense. We can do it in next PRs.

andrescrz commented 1 week ago

Please update the readme in code_generation so that everybody know we now have this script

Done in revision 2.