search

comfy / comfortable-mexican-sofa

ComfortableMexicanSofa is a powerful Ruby on Rails 5.2+ CMS (Content Management System) Engine
MIT License
2.72k stars 637 forks source link

issues#925 #931

Open donrestarone opened 3 years ago

donrestarone commented 3 years ago

Summary

Fixing this issue: https://github.com/comfy/comfortable-mexican-sofa/issues/925

TL;DR Looks like we don't have to use the option combine_options: to pass the hash that is returned by Comfy::Cms::File::VARIANT_SIZE[:thumb]

donrestarone commented 3 years ago

PS: Not sure if Im the only who experienced this but activestorage has changed from under us. I included the migration along with the fix for posterity. I'd be happy to remove it if isn't within scope :+1:

Fodoj commented 3 years ago

You should also change it at least here - https://github.com/comfy/comfortable-mexican-sofa/blob/8f7e425a06aca9cfa8e21de6b7a10669c8495fc3/app/controllers/comfy/admin/cms/files_controller.rb#L26. I would not add those migrations though.